jorgecarleitao commented on pull request #7971: URL: https://github.com/apache/arrow/pull/7971#issuecomment-675520454
I am fine with either option we offer to our users. My concern at the moment is not the public API, but the internal one: after spending some time working on this code base, I now do believe that we are much better served by: 1. describing all our internal functions as generic functions with a variable output type (that may be a constant function) 2. migrate all our aggregates to generic functions. With this, we have a very simple way to add new functions, both aggregates and scalars, both with variable and fixed types. With this in place, we can trivially expose an interface to our users that supports a single return type; we just need to change our public interface to narrow the function registration to accept a single type. Regardless, I am closing this as I can see that @andygrove plans to work over this functionality. I will help on the review. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
