viirya commented on a change in pull request #1469: URL: https://github.com/apache/arrow-rs/pull/1469#discussion_r835960131
########## File path: arrow/src/array/equal/union.rs ########## @@ -0,0 +1,171 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use crate::datatypes::Field; +use crate::{ + array::ArrayData, buffer::Buffer, datatypes::DataType, datatypes::UnionMode, +}; + +use super::{ + equal_range, equal_values, utils::child_logical_null_buffer, utils::equal_nulls, +}; + +// Checks if corresponding slots in two UnionArrays are same data types +fn equal_types( Review comment: Hmm, even type_ids are different, isn't it still possible that the union arrays are equal? For example, the fields are int, int, float, string. If lhs type_ids is 1, but rhs type_id is 0, they are both int. We don't know if the actual element at child arrays are equal or not. So here I compare if the type_ids are the same type or not, not its values. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
