tustvold commented on a change in pull request #1469: URL: https://github.com/apache/arrow-rs/pull/1469#discussion_r836182203
########## File path: arrow/src/array/equal/union.rs ########## @@ -0,0 +1,171 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use crate::datatypes::Field; +use crate::{ + array::ArrayData, buffer::Buffer, datatypes::DataType, datatypes::UnionMode, +}; + +use super::{ + equal_range, equal_values, utils::child_logical_null_buffer, utils::equal_nulls, +}; + +// Checks if corresponding slots in two UnionArrays are same data types +fn equal_types( Review comment: In the case of two fields with the same type, I believe these must still have field names and therefore there is a logical difference between values stored in one vs the other. I'm not sure about this though, possibly worth an upstream clarification 🤔 On the case of different field ordering the arrays can never compare equal as they have different data types. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
