joosthooz commented on a change in pull request #12609:
URL: https://github.com/apache/arrow/pull/12609#discussion_r838524441



##########
File path: cpp/src/parquet/arrow/reader.cc
##########
@@ -1173,15 +1187,13 @@ Future<std::shared_ptr<Table>> 
FileReaderImpl::DecodeRowGroups(
   // OptionalParallelForAsync requires an executor
   if (!cpu_executor) cpu_executor = ::arrow::internal::GetCpuThreadPool();
 
-  auto read_column = [row_groups, self, this](size_t i,
-                                              
std::shared_ptr<ColumnReaderImpl> reader)
+  auto read_column = [=](size_t i, std::shared_ptr<ColumnReaderImpl> reader) 
mutable

Review comment:
       No, I reverted it

##########
File path: cpp/src/parquet/arrow/reader.cc
##########
@@ -1060,7 +1072,8 @@ class RowGroupGenerator {
     }
     auto ready = reader->parquet_reader()->WhenBuffered({row_group}, 
column_indices);
     if (cpu_executor_) ready = cpu_executor_->TransferAlways(ready);
-    return ready.Then([=]() -> ::arrow::Future<RecordBatchGenerator> {
+
+    return ready.Then([=]() mutable -> ::arrow::Future<RecordBatchGenerator> {

Review comment:
       No, I reverted it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to