joosthooz commented on a change in pull request #12609:
URL: https://github.com/apache/arrow/pull/12609#discussion_r838524843
##########
File path: cpp/src/arrow/util/thread_pool.h
##########
@@ -144,12 +144,12 @@ class ARROW_EXPORT Executor {
// will return the callable's result value once.
// The callable's arguments are copied before execution.
template <typename Function, typename... Args,
+ typename FuncResult = ::arrow::detail::result_of_t<Function &&
(Args && ...)>,
typename FutureType = typename
::arrow::detail::ContinueFuture::ForSignature<
Function && (Args && ...)>>
Result<FutureType> Submit(TaskHints hints, StopToken stop_token, Function&&
func,
Args&&... args) {
using ValueType = typename FutureType::ValueType;
-
auto future = FutureType::Make();
Review comment:
No, I reverted these
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
