djnavarro commented on a change in pull request #12154:
URL: https://github.com/apache/arrow/pull/12154#discussion_r839044292
##########
File path: r/src/compute.cpp
##########
@@ -521,6 +521,20 @@ std::shared_ptr<arrow::compute::FunctionOptions>
make_compute_options(
return out;
}
+ if (func_name == "round_temporal" || func_name == "floor_temporal" ||
+ func_name == "ceil_temporal") {
+ using Options = arrow::compute::RoundTemporalOptions;
+ auto out = std::make_shared<Options>(Options::Defaults());
+ SEXP unit = options["unit"];
+ if (!Rf_isNull(unit)) {
+ out->unit = cpp11::as_cpp<enum arrow::compute::CalendarUnit>(unit);
+ }
+ if (!Rf_isNull(options["multiple"])) {
+ out->multiple = cpp11::as_cpp<int64_t>(options["multiple"]);
+ }
+ return out;
+ }
Review comment:
Ah thanks! I hadn't even had time to work out what was going on yet,
this is super helpful and would have taken me a while to get there 😁
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
