djnavarro commented on a change in pull request #12154:
URL: https://github.com/apache/arrow/pull/12154#discussion_r839048142
##########
File path: r/src/compute.cpp
##########
@@ -521,6 +521,20 @@ std::shared_ptr<arrow::compute::FunctionOptions>
make_compute_options(
return out;
}
+ if (func_name == "round_temporal" || func_name == "floor_temporal" ||
+ func_name == "ceil_temporal") {
+ using Options = arrow::compute::RoundTemporalOptions;
+ auto out = std::make_shared<Options>(Options::Defaults());
+ SEXP unit = options["unit"];
+ if (!Rf_isNull(unit)) {
Review comment:
lol. TIL what "add suggestion to batch" is for, by not using it when I
should have 🙃
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
