emkornfield commented on code in PR #12763:
URL: https://github.com/apache/arrow/pull/12763#discussion_r852558632
##########
cpp/src/arrow/filesystem/gcsfs.cc:
##########
@@ -690,11 +745,17 @@ Result<GcsOptions> GcsOptions::FromUri(const
arrow::internal::Uri& uri,
options_map.emplace(kv.first, kv.second);
}
- if (!uri.password().empty() || !uri.username().empty()) {
- return Status::Invalid("GCS does not accept username or password.");
+ const std::string& username = uri.username();
+ bool anonymous = username == "anonymous";
+ if (!uri.password().empty() || (!username.empty() && !anonymous)) {
+ return Status::Invalid(
+ "GCS does not accept username except \"anonymous\" or password.");
}
Review Comment:
yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
