emkornfield commented on code in PR #12763:
URL: https://github.com/apache/arrow/pull/12763#discussion_r852559354
##########
cpp/src/arrow/filesystem/gcsfs.cc:
##########
@@ -536,8 +546,7 @@ class GcsFileSystem::Impl {
gcs::ReadFromOffset
offset) {
auto stream = client_.ReadObject(path.bucket, path.object, generation,
offset);
ARROW_GCS_RETURN_NOT_OK(stream.status());
- return std::make_shared<GcsInputStream>(std::move(stream), path,
gcs::Generation(),
- offset, client_);
+ return std::make_shared<GcsInputStream>(std::move(stream), path,
generation, client_);
Review Comment:
I don't think generic file systems have any notion of generation. This
probably needs to be an enhancement to the GCS unit tests, but I'm not sure
test bench supports generation? @coryan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
