tustvold commented on code in PR #1589:
URL: https://github.com/apache/arrow-rs/pull/1589#discussion_r853513902
##########
arrow/src/array/equal/utils.rs:
##########
@@ -47,8 +47,13 @@ pub(super) fn equal_nulls(
rhs_start: usize,
len: usize,
) -> bool {
- let lhs_null_count = count_nulls(lhs_nulls, lhs_start, len);
- let rhs_null_count = count_nulls(rhs_nulls, rhs_start, len);
+ let lhs_null_count = count_nulls(lhs_nulls, lhs_start + lhs.offset(), len);
Review Comment:
equal_bits a few lines is correctly taking into account the offset, but this
line wasn't => excitement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
