tustvold commented on code in PR #1589:
URL: https://github.com/apache/arrow-rs/pull/1589#discussion_r854874816
##########
arrow/src/array/equal/boolean.rs:
##########
@@ -16,25 +16,22 @@
// under the License.
use crate::array::{data::count_nulls, ArrayData};
-use crate::buffer::Buffer;
use crate::util::bit_util::get_bit;
use super::utils::{equal_bits, equal_len};
pub(super) fn boolean_equal(
lhs: &ArrayData,
rhs: &ArrayData,
- lhs_nulls: Option<&Buffer>,
- rhs_nulls: Option<&Buffer>,
mut lhs_start: usize,
mut rhs_start: usize,
mut len: usize,
) -> bool {
let lhs_values = lhs.buffers()[0].as_slice();
let rhs_values = rhs.buffers()[0].as_slice();
- let lhs_null_count = count_nulls(lhs_nulls, lhs_start, len);
- let rhs_null_count = count_nulls(rhs_nulls, rhs_start, len);
+ let lhs_null_count = count_nulls(lhs.null_buffer(), lhs_start +
lhs.offset(), len);
+ let rhs_null_count = count_nulls(rhs.null_buffer(), rhs_start +
rhs.offset(), len);
Review Comment:
Yes, in lots of places 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
