wjones127 commented on code in PR #2246:
URL: https://github.com/apache/arrow-datafusion/pull/2246#discussion_r853622692
##########
ballista/rust/core/src/serde/logical_plan/mod.rs:
##########
@@ -1016,6 +1016,55 @@ mod roundtrip_tests {
"this is only a test object store".to_string(),
))
}
+
+ fn file_writer(
+ &self,
+ _path: &str,
+ ) -> datafusion_data_access::Result<Arc<dyn ObjectWriter>> {
+ unimplemented!();
+ }
+
+ async fn create_dir(
Review Comment:
That's a good point. I didn't know that was the behavior in C++ Arrow. I
started a sibling PR to implement these methods for S3 in
https://github.com/datafusion-contrib/datafusion-objectstore-s3/pull/54, so I
might prototype some more there and see if that's necessary in any way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
