wjones127 commented on code in PR #2246:
URL: https://github.com/apache/arrow-datafusion/pull/2246#discussion_r853632070
##########
ballista/rust/core/src/serde/logical_plan/mod.rs:
##########
@@ -1016,6 +1016,55 @@ mod roundtrip_tests {
"this is only a test object store".to_string(),
))
}
+
+ fn file_writer(
+ &self,
+ _path: &str,
+ ) -> datafusion_data_access::Result<Arc<dyn ObjectWriter>> {
+ unimplemented!();
+ }
+
+ async fn create_dir(
+ &self,
+ _path: &str,
+ _recursive: bool,
+ ) -> datafusion_data_access::Result<()> {
+ unimplemented!();
+ }
+
+ async fn remove_dir_all(
+ &self,
+ _path: &str,
+ ) -> datafusion_data_access::Result<()> {
+ unimplemented!();
+ }
+
+ async fn remove_dir_contents(
+ &self,
+ _path: &str,
+ ) -> datafusion_data_access::Result<()> {
+ unimplemented!();
+ }
+
+ async fn remove_file(&self, _path: &str) ->
datafusion_data_access::Result<()> {
+ unimplemented!();
+ }
+
+ async fn rename(
Review Comment:
AFAIK, in Rust you can't override implementations from a trait, so I'm
reluctant to provide a default implementation. But agreed that as far as I can
see that does seem to be the pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
