dragosmg commented on code in PR #12738:
URL: https://github.com/apache/arrow/pull/12738#discussion_r853955788
##########
r/tests/testthat/test-dplyr-funcs-type.R:
##########
@@ -854,21 +874,94 @@ test_that("as.Date() converts successfully from date,
timestamp, integer, char a
fixed = TRUE
)
- # we do not support as.Date() with double/ float
- compare_dplyr_binding(
- .input %>%
+
+ # we do not support as.Date() with double/ float (error surfaced from C++)
+ # TODO revisit after https://issues.apache.org/jira/browse/ARROW-15798
+ expect_error(
+ test_df %>%
+ arrow_table() %>%
mutate(date_double = as.Date(double_var, origin = "1970-01-01")) %>%
+ collect()
+ )
+
+ # we do not support as_date with double/ float (error surfaced from C++)
+ # TODO revisit after https://issues.apache.org/jira/browse/ARROW-15798
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
