dragosmg commented on code in PR #12738:
URL: https://github.com/apache/arrow/pull/12738#discussion_r854370594
##########
r/tests/testthat/test-dplyr-funcs-type.R:
##########
@@ -854,21 +874,94 @@ test_that("as.Date() converts successfully from date,
timestamp, integer, char a
fixed = TRUE
)
- # we do not support as.Date() with double/ float
- compare_dplyr_binding(
- .input %>%
+
+ # we do not support as.Date() with double/ float (error surfaced from C++)
+ # TODO revisit after https://issues.apache.org/jira/browse/ARROW-15798
+ expect_error(
+ test_df %>%
+ arrow_table() %>%
mutate(date_double = as.Date(double_var, origin = "1970-01-01")) %>%
+ collect()
+ )
+
+ # we do not support as_date with double/ float (error surfaced from C++)
+ # TODO revisit after https://issues.apache.org/jira/browse/ARROW-15798
+ expect_error(
+ test_df %>%
+ arrow_table() %>%
+ mutate(date_double = as_date(double_var, origin = "1970-01-01")) %>%
+ collect()
+ )
+
+ # difference between as.Date() and as_date():
+ #`as.Date()` ignores the `tzone` attribute and uses the value of the `tz` arg
+ # to `as.Date()`
+ # `as_date()` does the opposite: uses the tzone attribute of the POSIXct
object
+ # passsed if`tz` is NULL
+ compare_dplyr_binding(
+ .input %>%
+ transmute(
+ date_diff_lubridate = as_date(difference_date),
+ date_diff_base = as.Date(difference_date)
+ ) %>%
+ collect(),
+ test_df
+ )
+})
+
+test_that("`as_datetime()`", {
+ test_df <- tibble(
+ date = as.Date(c("2022-03-22", "2021-07-30", NA)),
+ char_date = c("2022-03-22", "2021-07-30 14:32:47", NA),
+ char_date_non_iso = c("2022-22-03 12:34:56", "2021-30-07 14:32:47", NA),
+ int_date = c(10L, 25L, NA),
+ integerish_date = c(10, 25, NA),
+ double_date = c(10.1, 25.2, NA)
+ )
+
+ test_df %>%
+ arrow_table() %>%
+ mutate(
+ ddate = as_datetime(date),
+ dchar_date_no_tz = as_datetime(char_date),
+ dchar_date_non_iso = as_datetime(char_date_non_iso, format = "%Y-%d-%m
%H:%M:%S"),
+ dint_date = as_datetime(int_date, origin = "1970-01-02"),
+ dintegerish_date = as_datetime(integerish_date, origin = "1970-01-02"),
+ dintegerish_date2 = as_datetime(integerish_date, origin = "1970-01-01")
+ ) %>%
+ collect()
+
+ compare_dplyr_binding(
+ .input %>%
+ mutate(
+ ddate = as_datetime(date),
+ dchar_date_no_tz = as_datetime(char_date),
+ dint_date = as_datetime(int_date, origin = "1970-01-02"),
+ dintegerish_date = as_datetime(integerish_date, origin = "1970-01-02"),
+ dintegerish_date2 = as_datetime(integerish_date, origin = "1970-01-01")
+ ) %>%
+ collect(),
+ test_df
+ )
+
+ # Arrow does not support conversion of double to date
+ # the below should error with an error message originating in the C++ code
+ expect_error(
+ test_df %>%
+ arrow_table() %>%
+ mutate(
+ ddouble_date = as_datetime(double_date)
+ ) %>%
collect(),
- test_df,
- warning = TRUE
+ regexp = "Float value 10.1 was truncated converting to int64"
)
+ # separate tz test so we can skip on Windows
skip_on_os("windows") # https://issues.apache.org/jira/browse/ARROW-13168
Review Comment:
I had removed those relevant for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
