dragosmg commented on code in PR #12738:
URL: https://github.com/apache/arrow/pull/12738#discussion_r854918626
##########
r/R/dplyr-funcs-datetime.R:
##########
@@ -463,3 +463,54 @@ duration_from_chunks <- function(chunks) {
}
duration
}
+
+binding_as_date <- function(x,
+ format = NULL,
+ tryFormats = "%Y-%m-%d",
+ origin = "1970-01-01",
+ use_tz = "UTC",
+ base = TRUE) {
Review Comment:
I see what you mean now. I have a new variant in which `binding_as_date()`
no longer needs a `tz` argument since `tz` is used outside it (inside the
binding definition). I kinda like this approach as it brings front and center
the difference between `base::as.Date()` and `lubridate::as_date()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
