viirya commented on code in PR #1621:
URL: https://github.com/apache/arrow-rs/pull/1621#discussion_r860296880
##########
parquet/src/column/writer.rs:
##########
@@ -2153,4 +2346,94 @@ mod tests {
panic!("metadata missing statistics");
}
}
+
+ /// Returns Decimals column writer.
+ fn get_test_decimals_column_writer<T: DataType>(
+ page_writer: Box<dyn PageWriter>,
+ max_def_level: i16,
+ max_rep_level: i16,
+ props: WriterPropertiesPtr,
+ ) -> ColumnWriterImpl<T> {
+ let descr = Arc::new(get_test_decimals_column_descr::<T>(
+ max_def_level,
+ max_rep_level,
+ ));
+ let column_writer = get_column_writer(descr, props, page_writer);
+ get_typed_column_writer::<T>(column_writer)
+ }
+
+ /// Returns decimals column reader.
+ fn get_test_decimals_column_reader<T: DataType>(
+ page_reader: Box<dyn PageReader>,
+ max_def_level: i16,
+ max_rep_level: i16,
+ ) -> ColumnReaderImpl<T> {
+ let descr = Arc::new(get_test_decimals_column_descr::<T>(
+ max_def_level,
+ max_rep_level,
+ ));
+ let column_reader = get_column_reader(descr, page_reader);
+ get_typed_column_reader::<T>(column_reader)
+ }
+
+ /// Returns descriptor for Decimal type with primitive column.
+ fn get_test_decimals_column_descr<T: DataType>(
+ max_def_level: i16,
+ max_rep_level: i16,
+ ) -> ColumnDescriptor {
+ let path = ColumnPath::from("col");
+ let tpe = SchemaType::primitive_type_builder("col",
T::get_physical_type())
+ .with_length(16)
+ .with_logical_type(Some(LogicalType::Decimal {
+ scale: 2,
+ precision: 3,
+ }))
+ .with_scale(2)
+ .with_precision(3)
+ .build()
+ .unwrap();
+ ColumnDescriptor::new(Arc::new(tpe), max_def_level, max_rep_level,
path)
+ }
+
+ /// Returns column writer for UINT32 Column (Provided as ConvertedType
without specifying the LogicalType).
+ fn get_test_unsigned_int_given_as_converted_column_writer<T: DataType>(
Review Comment:
Hmm, where is this used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
