atefsawaed commented on code in PR #1621:
URL: https://github.com/apache/arrow-rs/pull/1621#discussion_r861033402
##########
parquet/src/column/writer.rs:
##########
@@ -1006,6 +1006,41 @@ impl<T: DataType> ColumnWriterImpl<T> {
return a.as_u64().unwrap() > b.as_u64().unwrap();
}
}
+
+ match self.descr.converted_type() {
+ ConvertedType::UINT_8
+ | ConvertedType::UINT_16
+ | ConvertedType::UINT_32
+ | ConvertedType::UINT_64 => {
+ return a.as_u64().unwrap() > b.as_u64().unwrap();
+ }
+ _ => {}
+ };
+
+ if let Some(LogicalType::Decimal { .. }) = self.descr.logical_type() {
+ match self.descr.physical_type() {
Review Comment:
That's right. In this case, signed comparison of the integer values produces
the correct ordering and will be done in line 1044.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
