niyue commented on code in PR #13041:
URL: https://github.com/apache/arrow/pull/13041#discussion_r862430522
##########
cpp/src/arrow/ipc/writer.h:
##########
@@ -104,8 +104,7 @@ class ARROW_EXPORT RecordBatchWriter {
virtual Status WriteRecordBatch(
const RecordBatch& batch,
const std::shared_ptr<const KeyValueMetadata>& custom_metadata) {
- return Status::NotImplemented(
- "Write record batch with custom metadata not implemented");
+ return WriteRecordBatch(batch);
Review Comment:
In https://github.com/apache/arrow/pull/12812, @pitrou
[suggested](https://github.com/apache/arrow/pull/12812#issuecomment-1097832538)
to ignore the custom_metadata by default. By I somehow missed that part and the
default implementation is throwing an error. When I was adding this API in
pyarrow, I found one test case failed
(https://github.com/apache/arrow/blob/master/python/pyarrow/tests/test_csv.py#L1895).
And in this csv test case, it uses the `CsvWriter` which doesn't implement
this API signature.
Since storing custom metadata is an IPC feature, probably other
serialization won't support this so far, I realize probably we should switch
the default implementation to discarding the provided custom_metadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
