jorgecarleitao commented on pull request #8032: URL: https://github.com/apache/arrow/pull/8032#issuecomment-683255964
FYI, this is what a PR to add support for f32 to mathematical expressions (keeping the return type f64) looks like: https://github.com/jorgecarleitao/arrow/pull/1 I.e. IMO with this PR we can support almost any built-in function: fixed type, variable return type, multiple input types, etc on `Expr::ScalarFunction`, which gives a lot of flexibility to add a new function, as we do not need to fiddle with `Expr`, only with input types, return types, etc. on the physical plane. I split built-ins from the UDFs because built-ins type is known without access to the registry, which is currently required to allow users to use them outside the `registry`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
