andygrove commented on a change in pull request #8032:
URL: https://github.com/apache/arrow/pull/8032#discussion_r483001402
##########
File path: rust/datafusion/src/dataframe.rs
##########
@@ -188,4 +188,19 @@ pub trait DataFrame {
/// # }
/// ```
fn explain(&self, verbose: bool) -> Result<Arc<dyn DataFrame>>;
+
+ /// Return a `FunctionRegistry` used to plan udf's calls
+ ///
+ /// ```
+ /// # use datafusion::prelude::*;
+ /// # use datafusion::error::Result;
+ /// # fn main() -> Result<()> {
+ /// let mut ctx = ExecutionContext::new();
+ /// let df = ctx.read_csv("tests/example.csv", CsvReadOptions::new())?;
+ /// let f = df.registry();
+ /// // use f.udf("name", vec![...]) to use the udf
+ /// # Ok(())
+ /// # }
+ /// ```
+ fn registry(&self) -> &dyn FunctionRegistry;
Review comment:
Is this registry specific to scalar functions or will it also be used
for aggregate functions? Perhaps we should name the method either
`function_registry` or `scalar_function_registry`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
