tustvold commented on code in PR #1634:
URL: https://github.com/apache/arrow-rs/pull/1634#discussion_r862772438
##########
parquet/src/arrow/arrow_writer.rs:
##########
@@ -192,8 +196,8 @@ impl<W: 'static + ParquetWriter> ArrowWriter<W> {
/// Close and finalize the underlying Parquet writer
pub fn close(&mut self) -> Result<parquet_format::FileMetaData> {
- self.flush_completed()?;
- self.flush_row_group(self.buffered_rows)?;
+ self.flush_excess()?;
Review Comment:
I know this existed before, but I think it is actually redundant as `write`
calls `flush_excess`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
