Cheappie commented on code in PR #1634:
URL: https://github.com/apache/arrow-rs/pull/1634#discussion_r862821744
##########
parquet/src/arrow/arrow_writer.rs:
##########
@@ -192,8 +196,8 @@ impl<W: 'static + ParquetWriter> ArrowWriter<W> {
/// Close and finalize the underlying Parquet writer
pub fn close(&mut self) -> Result<parquet_format::FileMetaData> {
- self.flush_completed()?;
- self.flush_row_group(self.buffered_rows)?;
+ self.flush_excess()?;
Review Comment:
yep, It is redundant, I didn't want to remove that on my own because it
could be intentional to have defensive approach when closing writer, but right
now that seems unnecessary unless more options for write popup in ArrowWriter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
