alamb commented on a change in pull request #8080:
URL: https://github.com/apache/arrow/pull/8080#discussion_r480048622
##########
File path: rust/datafusion/src/sql/planner.rs
##########
@@ -592,7 +607,7 @@ mod tests {
fn select_scalar_func_with_literal_no_relation() {
quick_test(
"SELECT sqrt(9)",
- "Projection: sqrt(CAST(Int64(9) AS Float64))\
+ "Projection: sqrt(Int64(9))\
Review comment:
> For this reason, IMO these type of casting operations should only be
done on our physical plane. For example, a different physical planner could
prefer to not have it casted because it has a specialized implementation that
supports other types.
I hadn't thought of the idea that different physical planners might want to
do type coercion differently -- that is a good point and it makes sense to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
