jorgecarleitao commented on a change in pull request #8080:
URL: https://github.com/apache/arrow/pull/8080#discussion_r480263816
##########
File path: rust/datafusion/src/logicalplan.rs
##########
@@ -190,7 +190,14 @@ fn create_name(e: &Expr, input_schema: &Schema) ->
Result<String> {
let expr = create_name(expr, input_schema)?;
Ok(format!("CAST({} as {:?})", expr, data_type))
}
- Expr::ScalarFunction { name, args, .. } => {
+ Expr::ScalarFunction { fun, args, .. } => {
+ let mut names = Vec::with_capacity(args.len());
Review comment:
I agree. I kept it because the code around this change is using this
idiom. I would prefer to change that whole code (`ScalarUDF`,
`AggregateFunction`, `ScalarFunction`) in a separate commit to not want to
complicate even further this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
