timvw commented on code in PR #2444: URL: https://github.com/apache/arrow-datafusion/pull/2444#discussion_r865759797
########## dev/format-code.sh: ########## @@ -0,0 +1,22 @@ +#!/bin/bash Review Comment: Personally, I appreciate the fact that multiple steps/commands are visualised as multiple steps/commands in the build pipeline. It's not pleasant needing to dive into the error log to find out which step failed.. The CI build and the dev/lint-code script could be updated to invoke the same scripts (run_clippy.sh, run_xxx, ..) but unless the commands and/or their arguments change often, I would not bother.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
