tustvold commented on code in PR #2444: URL: https://github.com/apache/arrow-datafusion/pull/2444#discussion_r865879435
########## dev/format-code.sh: ########## @@ -0,0 +1,22 @@ +#!/bin/bash Review Comment: Definitely an option but you need to be careful about two things though: * Staging only the files that are relevant - https://github.com/influxdata/influxdb_iox/pull/839/files#diff-87320095d7c4f39eed5d8f3866b512eb910e4eec8e7926faaeef6a53ab786fcbR8 * Avoiding the git hook taking too long The latter is the really painful one because clippy is very slow, you get no output from git hooks, and they run on most git operations. Formatting could definitely be done in this way though -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
