rok commented on code in PR #12528:
URL: https://github.com/apache/arrow/pull/12528#discussion_r867157111
##########
cpp/src/arrow/compute/kernels/scalar_temporal_test.cc:
##########
@@ -2611,6 +2611,114 @@ TEST_F(ScalarTemporalTest, TestRoundTemporal) {
CheckScalarUnary(op, unit, times, unit, round_15_years, &round_to_15_years);
}
+TEST_F(ScalarTemporalTest, TestCeilFloorRoundTemporalAmbiguous1) {
+ // Asia/Tehran switches from UTC+4:30 to UTC+3:30 on 2022-09-22 00:00:00
UTC+4:30.
+ // This causes an hour long ambiguous period in local time.
+ auto unit = timestamp(TimeUnit::MILLI, "Asia/Tehran");
+ auto options = RoundTemporalOptions(1, CalendarUnit::HOUR,
/*some_parameter=*/true);
+ const char* times = R"([
+ "2022-03-21 19:30:00", "2022-03-21 20:00:00", "2022-03-21 20:30:00",
+ "2022-09-21 18:30:00", "2022-09-21 19:00:00", "2022-09-21 19:30:00",
+ "2022-09-21 20:00:00", "2022-09-21 20:30:00", "2022-09-21 21:00:00",
+ "2022-09-21 21:30:00"])";
+ const char* times_ceil = R"([
+ "2022-03-21 19:30:00", "2022-03-21 20:30:00", "2022-03-21 20:30:00",
+ "2022-09-21 18:30:00", "2022-09-21 19:30:00", "2022-09-21 19:30:00",
+ "2022-09-21 20:30:00", "2022-09-21 20:30:00", "2022-09-21 21:30:00",
+ "2022-09-21 21:30:00"])";
+ const char* times_floor = R"([
+ "2022-03-21 19:30:00", "2022-03-21 19:30:00", "2022-03-21 20:30:00",
+ "2022-09-21 18:30:00", "2022-09-21 18:30:00", "2022-09-21 19:30:00",
+ "2022-09-21 19:30:00", "2022-09-21 20:30:00", "2022-09-21 20:30:00",
+ "2022-09-21 21:30:00"])";
+ const char* times_round = R"([
+ "2022-03-21 19:30:00", "2022-03-21 20:30:00", "2022-03-21 20:30:00",
+ "2022-09-21 18:30:00", "2022-09-21 19:30:00", "2022-09-21 19:30:00",
Review Comment:
Done. It actually surfaced a potential problem I need to fxi.
##########
cpp/src/arrow/compute/kernels/scalar_temporal_test.cc:
##########
@@ -2611,6 +2611,114 @@ TEST_F(ScalarTemporalTest, TestRoundTemporal) {
CheckScalarUnary(op, unit, times, unit, round_15_years, &round_to_15_years);
}
+TEST_F(ScalarTemporalTest, TestCeilFloorRoundTemporalAmbiguous1) {
+ // Asia/Tehran switches from UTC+4:30 to UTC+3:30 on 2022-09-22 00:00:00
UTC+4:30.
+ // This causes an hour long ambiguous period in local time.
+ auto unit = timestamp(TimeUnit::MILLI, "Asia/Tehran");
+ auto options = RoundTemporalOptions(1, CalendarUnit::HOUR,
/*some_parameter=*/true);
+ const char* times = R"([
+ "2022-03-21 19:30:00", "2022-03-21 20:00:00", "2022-03-21 20:30:00",
+ "2022-09-21 18:30:00", "2022-09-21 19:00:00", "2022-09-21 19:30:00",
+ "2022-09-21 20:00:00", "2022-09-21 20:30:00", "2022-09-21 21:00:00",
+ "2022-09-21 21:30:00"])";
+ const char* times_ceil = R"([
+ "2022-03-21 19:30:00", "2022-03-21 20:30:00", "2022-03-21 20:30:00",
+ "2022-09-21 18:30:00", "2022-09-21 19:30:00", "2022-09-21 19:30:00",
+ "2022-09-21 20:30:00", "2022-09-21 20:30:00", "2022-09-21 21:30:00",
+ "2022-09-21 21:30:00"])";
+ const char* times_floor = R"([
+ "2022-03-21 19:30:00", "2022-03-21 19:30:00", "2022-03-21 20:30:00",
+ "2022-09-21 18:30:00", "2022-09-21 18:30:00", "2022-09-21 19:30:00",
+ "2022-09-21 19:30:00", "2022-09-21 20:30:00", "2022-09-21 20:30:00",
+ "2022-09-21 21:30:00"])";
+ const char* times_round = R"([
+ "2022-03-21 19:30:00", "2022-03-21 20:30:00", "2022-03-21 20:30:00",
+ "2022-09-21 18:30:00", "2022-09-21 19:30:00", "2022-09-21 19:30:00",
Review Comment:
Done. It actually surfaced a potential problem I need to fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
