rok commented on code in PR #12528:
URL: https://github.com/apache/arrow/pull/12528#discussion_r871540501
##########
cpp/src/arrow/compute/kernels/temporal_internal.h:
##########
@@ -119,19 +178,109 @@ struct ZonedLocalizer {
return tz->to_local(sys_time<Duration>(Duration{t}));
}
+ template <typename Duration, typename Unit>
+ Duration FloorTimePoint(const int64_t t, const RoundTemporalOptions&
options) const {
+ const local_time<Duration> lt =
tz->to_local(sys_time<Duration>(Duration{t}));
Review Comment:
If you mean `arrow_vendored::date::choose::earliest` then the result is the
beginning of an ambiguous period which is not really a multiple of a time unit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
