viirya commented on code in PR #1665:
URL: https://github.com/apache/arrow-rs/pull/1665#discussion_r867268461
##########
arrow/src/compute/kernels/substring.rs:
##########
@@ -954,6 +992,56 @@ mod tests {
without_nulls_generic_string::<i64>()
}
+ #[test]
+ fn dictionary() -> Result<()> {
Review Comment:
```suggestion
fn test_string_dictionary() -> Result<()> {
```
##########
arrow/src/compute/kernels/substring.rs:
##########
@@ -954,6 +992,56 @@ mod tests {
without_nulls_generic_string::<i64>()
}
+ #[test]
+ fn dictionary() -> Result<()> {
Review Comment:
```suggestion
fn test_substring_dictionary() -> Result<()> {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
