sunchao commented on code in PR #1665:
URL: https://github.com/apache/arrow-rs/pull/1665#discussion_r867275202
##########
arrow/src/compute/kernels/substring.rs:
##########
@@ -954,6 +992,56 @@ mod tests {
without_nulls_generic_string::<i64>()
}
+ #[test]
+ fn dictionary() -> Result<()> {
Review Comment:
I think it's not necessary to add `test_` prefix for Rust tests since they
are already under the `tests` module. The `substring` here also seem redundant
since the full test name `compute::kernels::substring::tests::dictionary`
already contain it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
