icexelloss commented on PR #13028:
URL: https://github.com/apache/arrow/pull/13028#issuecomment-1124049974
@westonpace I am sort of stuck on this PR and can use some help.
- CI
The CI appears to be failed due to a GTest issue:
```
Building Substrait from source
-- Building (vendored) mimalloc from source
CMake Error at cmake_modules/ThirdpartyToolchain.cmake:239 (find_package):
Could not find a package configuration file provided by "GTest" (requested
version 1.10.0) with any of the following names:
GTestConfig.cmake
gtest-config.cmake
Add the installation prefix of "GTest" to CMAKE_PREFIX_PATH or set
"GTest_DIR" to a directory containing one of the above files. If "GTest"
provides a separate development package or SDK, be sure it has been
installed.
Call Stack (most recent call first):
cmake_modules/ThirdpartyToolchain.cmake:1972 (resolve_dependency)
CMakeLists.txt:552 (include)
```
I am not sure what causes this issue or if this is something I did - any
suggestions?
- Lint & Code Style
I have been trying to deal with lint the past day or two and has very
limited success. I am able to run `ninja format lint clang-tidy lint_cpp_cli`
but it takes a very long time (hours?) and reformatted / gave errors on some
files that I do not touch. (I think clang-tidy is the one that is particular
problematic). I wonder if I did something wrong. (I installed clang-format 12)
* The iwyu step doesn't seem to work for me. I followed the instruction and
run until `./$IWYU_SH match arrow/compute/exec/` but it doesn't seem to remove
any includes. I ran
```
cmake .. --preset ninja-debug-basic -DCMAKE_EXPORT_COMPILE_COMMANDS=ON
```
(Didn't run the exact cmake command from the development doc because I it
gives me an missing openSSL error when configuring for some subcomponents)
then
```
(arrow-dev) icexelloss@LiUbuntu:~/workspace/arrow/cpp/iwyu$ $IWYU_SH match
arrow/compute/exec/asof
include-what-you-use 0.17 based on Ubuntu clang version 13.0.1-2ubuntu2
Running IWYU on
/home/icexelloss/workspace/arrow/cpp/src/arrow/compute/exec/asof_join.h
/home/icexelloss/workspace/arrow/cpp/src/arrow/compute/exec/asof_join_node.cc
/home/icexelloss/workspace/arrow/cpp/src/arrow/compute/exec/asof_join_node_test.cc
```
but nothing seem to have changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
