westonpace commented on PR #13028: URL: https://github.com/apache/arrow/pull/13028#issuecomment-1124200663
Thank you for asking. I think I probably should have been clearer. It sounds like you might be doing more than is needed (we should maybe update our developer docs or put some work into getting these pieces working again). > The CI appears to be failed due to a GTest issue: Yes, this particular GTest issue is not related to your change. I think it's being worked on but you don't need to worry about it. > Lint & Code Style I wouldn't worry about running clang-tidy. As long as you don't get any compiler warnings and pass `clang format` then that should be good enough. Not all style issues have static checks however. For example, `concurrent_queue` should be `ConcurrentQueue` but we can do a code review to look for those. > The iwyu step doesn't seem to work for me. I don't know that it works for anyone. I would say that our philosophy is iwyu but we don't have any way of enforcing it. So this is more of a "if you have any doubts use the rules of iwyu to know what to include" but don't stress too much if you might have missed something. If you remove `[WIP]` from your title then more CI jobs should run. As long as these are passing I think we can catch any remaining style issues in code review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
