rok commented on PR #12528: URL: https://github.com/apache/arrow/pull/12528#issuecomment-1125003206
> I don't think that is correct, because 3h08 is not a multiple of 16 minutes: > > ``` > >>> divmod(3*60+8, 16) > (11, 12) > ``` If we do the rounding in local time the offset in UTC changes at DST jumps. I originally generated test cases by rounding just prior DST jump and continued in equal steps through nonexistent time. After the nonexistent time I would continue with regular rounding in local time. I am getting a bit test blind so I could really use help validating current test data or getting new test data :). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
