rok commented on PR #12528: URL: https://github.com/apache/arrow/pull/12528#issuecomment-1140040492
I've added Python tests to test the C++ implementation. Here are some visualisations of current behaviour:   And here's the Jupyter notebook used to generate visualisations: https://gist.github.com/rok/95140c58b4e516508866cf1367071e81 @jorisvandenbossche adding `roll-forward/backward` [like clock](https://clock.r-lib.org/reference/posixt-rounding.html) might be a good idea. I don't like `shift-forward/backward` so much. We previously dismissed having multiple settings though. However it might be worth to reopened that to enable sortedness-maintaining and sortedness-destroying behaviour. Possible options: * Real local rounding (sortedness-destroying), currently implemented * roll-forward/backward (sortedness-maintaining) * NA * Throw error Please also note current behaviour has some odd jitter due to rounding from different offsets, see around 1am below:  I'm not sure there is an obvious way to address it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
