jorisvandenbossche commented on PR #12528: URL: https://github.com/apache/arrow/pull/12528#issuecomment-1125068996
BTW, I actually expected that the non-existing time case would still raise an error by default (based on https://github.com/apache/arrow/pull/12528#issuecomment-1062826028). Given that this is a much more corner case than the ambiguous time, I think it is fine that this isn't handled automatically. If we want to have some automatic inference of what the resulting time should be for the non-existent case: I suppose we still need to round in local time, but if you end up with a non-existent time like "02:56:00" like in the example above, in this case we should actually choose "01:56:00" as the correct local time. The logic to obtain this could be to check the earliest and latest valid time ("02:00" and "03:00"), check the difference between "01:56" and the latest, and then subtract that from the earliest time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
