jorisvandenbossche commented on PR #12528: URL: https://github.com/apache/arrow/pull/12528#issuecomment-1130093279
Personally, for me it would also help to have a few hardcoded tests, but with some specific cases and with comments explaining what (and why) the result should be (like "this time is ... in local time, rounding this gives ..., this is ambigous/nonexistent, so taking .. instead", and that for a few example cases) (for example you could take the ones that Antoine was commenting on, on the example case that we used above to discuss (https://github.com/apache/arrow/pull/12528#issuecomment-1124954128) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
