alamb opened a new pull request, #2531:
URL: https://github.com/apache/arrow-datafusion/pull/2531
# Which issue does this PR close?
N/A
# Rationale for this change
This test is important. It verifies that the memory use of code like
GroupByHash is not changed. Quoting:
```
// Since ScalarValues are used in a non trivial number of places,
// making it larger means significant more memory consumption
// per distinct value.
```
It turns out that the way the `cfgs` were setup the test never was invoked.
The change seems to have come in via #1455 from @maxburke
I found this while reviewing
https://github.com/apache/arrow-datafusion/pull/2523
# What changes are included in this PR?
Fix test so it is always invoked
# Are there any user-facing changes?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
