alamb commented on code in PR #2531:
URL: https://github.com/apache/arrow-datafusion/pull/2531#discussion_r872700708


##########
datafusion/core/src/scalar.rs:
##########
@@ -377,7 +377,7 @@ mod tests {
         #[cfg(target_arch = "aarch64")]
         assert_eq!(std::mem::size_of::<ScalarValue>(), 64);
 
-        #[cfg(target_arch = "amd64")]
+        #[cfg(not(target_arch = "aarch64"))]

Review Comment:
   ```
           let expected = match cfg!(target_arch == "aarch64") {
               true => 64,
               false => 48,
           };
   ```
   
   resulted in 
   
   ```
   error: expected 1 cfg-pattern
      --> datafusion/core/src/scalar.rs:380:30
       |
   380 |         let expected = match cfg!(target_arch == "aarch64") {
       |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
       |
       = note: this error originates in the macro `cfg` (in Nightly builds, run 
with -Z macro-backtrace for more info)
   
   ``` 
   
   for me locally



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to