icexelloss commented on code in PR #13028:
URL: https://github.com/apache/arrow/pull/13028#discussion_r882717495
##########
cpp/src/arrow/compute/exec/options.h:
##########
@@ -361,6 +361,19 @@ class ARROW_EXPORT HashJoinNodeOptions : public
ExecNodeOptions {
Expression filter;
};
+class ARROW_EXPORT AsofJoinNodeOptions : public ExecNodeOptions {
+ public:
+ AsofJoinNodeOptions(FieldRef time, FieldRef keys, int64_t tolerance)
+ : time(std::move(time)), keys(std::move(keys)), tolerance(tolerance) {}
+
+ // time column
Review Comment:
I agree these restrictions are not ideal. I put "Handle more datatypes (both
key and value)" as follow ups only in the interest of time.
> However, we should thoroughly document these limitations as well as test
for these when the node is created.
I agree. I can add tests for behaviors for when unsupported types are passed
in - do you have a pointer to some existing tests that test similar behaviors?
##########
cpp/src/arrow/compute/exec/options.h:
##########
@@ -361,6 +361,19 @@ class ARROW_EXPORT HashJoinNodeOptions : public
ExecNodeOptions {
Expression filter;
};
+class ARROW_EXPORT AsofJoinNodeOptions : public ExecNodeOptions {
+ public:
+ AsofJoinNodeOptions(FieldRef time, FieldRef keys, int64_t tolerance)
+ : time(std::move(time)), keys(std::move(keys)), tolerance(tolerance) {}
+
+ // time column
Review Comment:
I agree these restrictions are not ideal. I put "Handle more datatypes (both
key and value)" as follow ups only in the interest of time.
> However, we should thoroughly document these limitations as well as test
for these when the node is created.
I agree. I can add tests for behaviors for when unsupported types are passed
in - do you have a pointer to some existing tests that test similar behaviors?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
