icexelloss commented on code in PR #13028:
URL: https://github.com/apache/arrow/pull/13028#discussion_r886007031
##########
cpp/src/arrow/compute/exec/options.h:
##########
@@ -361,6 +361,19 @@ class ARROW_EXPORT HashJoinNodeOptions : public
ExecNodeOptions {
Expression filter;
};
+class ARROW_EXPORT AsofJoinNodeOptions : public ExecNodeOptions {
+ public:
+ AsofJoinNodeOptions(FieldRef time, FieldRef keys, int64_t tolerance)
+ : time(std::move(time)), keys(std::move(keys)), tolerance(tolerance) {}
+
+ // time column
+ FieldRef time;
+ // keys used for the join. All tables must have the same join key.
+ FieldRef keys;
Review Comment:
I agree. However, I'd prefer to leave as is since I will like to change this
anyway when integrating with substrait (i.e. comments here
https://github.com/apache/arrow/pull/13028/files#r882274989)
##########
cpp/src/arrow/compute/exec/options.h:
##########
@@ -361,6 +361,19 @@ class ARROW_EXPORT HashJoinNodeOptions : public
ExecNodeOptions {
Expression filter;
};
+class ARROW_EXPORT AsofJoinNodeOptions : public ExecNodeOptions {
+ public:
+ AsofJoinNodeOptions(FieldRef time, FieldRef keys, int64_t tolerance)
+ : time(std::move(time)), keys(std::move(keys)), tolerance(tolerance) {}
+
+ // time column
+ FieldRef time;
+ // keys used for the join. All tables must have the same join key.
+ FieldRef keys;
Review Comment:
I agree. However, I'd prefer to leave as is since I will like to change this
anyway when integrating with substrait (i.e. comments here
https://github.com/apache/arrow/pull/13028/files#r882274989) if that is OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
