save-buffer commented on code in PR #13143:
URL: https://github.com/apache/arrow/pull/13143#discussion_r882912625
##########
cpp/src/arrow/compute/exec/hash_join.cc:
##########
@@ -883,6 +875,8 @@ class HashJoinBasicImpl : public HashJoinImpl {
//
OutputBatchCallback output_batch_callback_;
FinishedCallback finished_callback_;
+ RegisterTaskGroupCallback register_task_group_callback_;
Review Comment:
Yeah, I've actually decided I want to keep the task groups inside the node
because I think it's a bit cleaner with the accumulation. This `Register` thing
will go away with the scheduler revamp too, so it'll be enough to just say "Run
this lambda 100 times for me".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
