save-buffer commented on code in PR #13143:
URL: https://github.com/apache/arrow/pull/13143#discussion_r882918417
##########
cpp/src/arrow/compute/exec/exec_plan.h:
##########
@@ -279,7 +293,7 @@ class ARROW_EXPORT ExecNode {
NodeVector outputs_;
// Future to sync finished
- Future<> finished_ = Future<>::MakeFinished();
+ Future<> finished_ = Future<>::Make();
Review Comment:
Yes, except we probably want a distinction between "everything that we
wanted to output has been outputted" and "we haven't finished outputting but we
didn't schedule enough tasks so we're stuck" (the second one being a bug).
So far the idea I have is to have `finished_` only on sink nodes, but that
also doesn't necessarily seem as clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
