tustvold commented on code in PR #1746:
URL: https://github.com/apache/arrow-rs/pull/1746#discussion_r882956255
##########
parquet/src/arrow/levels.rs:
##########
@@ -1475,81 +619,51 @@ mod tests {
let list_level = levels.get(0).unwrap();
let expected_level = LevelInfo {
- definition: vec![0, 0, 0, 0, 0],
- repetition: None,
- array_offsets: vec![0, 1, 2, 3, 4, 5],
- array_mask: vec![true, true, true, true, true],
- max_definition: 0,
- level_type: LevelType::Primitive(false),
- offset: 0,
- length: 5,
+ def_levels: None,
+ rep_levels: None,
+ non_null_indices: vec![0, 1, 2, 3, 4],
+ max_def_level: 0,
+ max_rep_level: 0,
};
assert_eq!(list_level, &expected_level);
// test "b" levels
let list_level = levels.get(1).unwrap();
let expected_level = LevelInfo {
- definition: vec![1, 0, 0, 1, 1],
- repetition: None,
- array_offsets: vec![0, 1, 2, 3, 4, 5],
- array_mask: vec![true, false, false, true, true],
- max_definition: 1,
- level_type: LevelType::Primitive(true),
- offset: 0,
- length: 5,
+ def_levels: Some(vec![1, 0, 0, 1, 1]),
+ rep_levels: None,
+ non_null_indices: vec![0, 3, 4],
+ max_def_level: 1,
+ max_rep_level: 0,
};
assert_eq!(list_level, &expected_level);
// test "d" levels
let list_level = levels.get(2).unwrap();
let expected_level = LevelInfo {
- definition: vec![1, 1, 1, 2, 1],
- repetition: None,
- array_offsets: vec![0, 1, 2, 3, 4, 5],
- array_mask: vec![false, false, false, true, false],
- max_definition: 2,
- level_type: LevelType::Primitive(true),
- offset: 0,
- length: 5,
+ def_levels: Some(vec![1, 1, 1, 2, 1]),
+ rep_levels: None,
+ non_null_indices: vec![3],
+ max_def_level: 2,
+ max_rep_level: 0,
};
assert_eq!(list_level, &expected_level);
// test "f" levels
let list_level = levels.get(3).unwrap();
let expected_level = LevelInfo {
- definition: vec![3, 2, 3, 2, 3],
- repetition: None,
- array_offsets: vec![0, 1, 2, 3, 4, 5],
- array_mask: vec![true, false, true, false, true],
- max_definition: 3,
- level_type: LevelType::Primitive(true),
- offset: 0,
- length: 5,
+ def_levels: Some(vec![3, 2, 3, 2, 3]),
+ rep_levels: None,
+ non_null_indices: vec![0, 2, 4],
+ max_def_level: 3,
+ max_rep_level: 0,
};
assert_eq!(list_level, &expected_level);
}
- #[test]
- fn test_filter_array_indices() {
Review Comment:
This function no longer exists
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
