tustvold commented on code in PR #1746:
URL: https://github.com/apache/arrow-rs/pull/1746#discussion_r883024098
##########
parquet/src/arrow/levels.rs:
##########
@@ -1475,81 +769,51 @@ mod tests {
let list_level = levels.get(0).unwrap();
let expected_level = LevelInfo {
- definition: vec![0, 0, 0, 0, 0],
- repetition: None,
- array_offsets: vec![0, 1, 2, 3, 4, 5],
- array_mask: vec![true, true, true, true, true],
- max_definition: 0,
- level_type: LevelType::Primitive(false),
- offset: 0,
- length: 5,
+ def_levels: None,
Review Comment:
Yes, the max definition level is 0, and so there is no need to compute
definition level data (it will not get written)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
