ahmedriza commented on PR #1746: URL: https://github.com/apache/arrow-rs/pull/1746#issuecomment-1139046024
This is fantastic. Checked my test cases against this PR and they work perfectly now. Also checked a few other combinations and they are all handled correctly now. * Empty arrays in `bids` column: ``` +---+----------------------+----+ |id |prices |bids| +---+----------------------+----+ |t1 |[[GBP, 3.14, [[LON]]]]|[] | |t2 |[[USD, 4.14, [[NYC]]]]|[] | +---+----------------------+----+ ``` * Nulls in `bids` column: ``` +---+----------------------+----+ |id |prices |bids| +---+----------------------+----+ |t1 |[[GBP, 3.14, [[LON]]]]|null| |t2 |[[USD, 4.14, [[NYC]]]]|null| +---+----------------------+----+ ``` * Mixture of non-null and null in `bids` column ``` +---+----------------------+------------------------+ |id |prices |bids | +---+----------------------+------------------------+ |t1 |[[GBP, 3.14, [[LON]]]]|[[JPY, 103.14, [[TKY]]]]| |t2 |[[USD, 4.14, [[NYC]]]]|null | +---+----------------------+------------------------+ ``` Amazing work. Thanks for the quick fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
