korowa commented on code in PR #2647:
URL: https://github.com/apache/arrow-datafusion/pull/2647#discussion_r884421525
##########
datafusion/sql/src/planner.rs:
##########
@@ -3837,10 +3759,9 @@ mod tests {
LEFT JOIN orders \
ON id = customer_id AND order_id > 1 AND age < 30";
let expected = "Projection: #person.id, #orders.order_id\
- \n Left Join: #person.id = #orders.customer_id Filter: #person.age <
Int64(30)\
+ \n Left Join: #person.id = #orders.customer_id Filter:
#orders.order_id > Int64(1) AND #person.age < Int64(30)\
\n TableScan: person projection=None\
- \n Filter: #orders.order_id > Int64(1)\
- \n TableScan: orders projection=None";
+ \n TableScan: orders projection=None";
Review Comment:
You're right, it can not anymore - now all predicate movements are on
`filter_push_down` optimizer, and there is no need for planner to define should
it push some filters down or not - it just creates plan node as it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
