korowa commented on code in PR #2647:
URL: https://github.com/apache/arrow-datafusion/pull/2647#discussion_r887587789
##########
datafusion/core/src/optimizer/filter_push_down.rs:
##########
@@ -1387,9 +1463,97 @@ mod tests {
Ok(())
}
+ /// join filter should be completely removed after pushdown
+ #[test]
+ fn join_filter_removed() -> Result<()> {
+ let table_scan = test_table_scan()?;
+ let left = LogicalPlanBuilder::from(table_scan)
+ .project(vec![col("a"), col("b"), col("c")])?
+ .build()?;
+ let right_table_scan = test_table_scan_with_name("test2")?;
+ let right = LogicalPlanBuilder::from(right_table_scan)
+ .project(vec![col("a"), col("b"), col("c")])?
+ .build()?;
+ let filter = col("test.b")
+ .gt(lit(1u32))
+ .and(col("test2.c").gt(lit(4u32)));
+ let plan = LogicalPlanBuilder::from(left)
+ .join(
+ &right,
+ JoinType::Inner,
+ (vec![Column::from_name("a")], vec![Column::from_name("a")]),
+ Some(filter),
+ )?
+ .build()?;
+
+ // not part of the test, just good to know:
+ assert_eq!(
+ format!("{:?}", plan),
+ "\
+ Inner Join: #test.a = #test2.a Filter: #test.b > UInt32(1) AND
#test2.c > UInt32(4)\
+ \n Projection: #test.a, #test.b, #test.c\
+ \n TableScan: test projection=None\
+ \n Projection: #test2.a, #test2.b, #test2.c\
+ \n TableScan: test2 projection=None"
+ );
+
+ let expected = "\
+ Inner Join: #test.a = #test2.a\
+ \n Projection: #test.a, #test.b, #test.c\
+ \n Filter: #test.b > UInt32(1)\
+ \n TableScan: test projection=None\
+ \n Projection: #test2.a, #test2.b, #test2.c\
+ \n Filter: #test2.c > UInt32(4)\
+ \n TableScan: test2 projection=None";
+ assert_optimized_plan_eq(&plan, expected);
+ Ok(())
+ }
+
+ /// predicate on join key in filter expression should be pushed down to
both inputs
+ #[test]
+ fn join_filter_on_common() -> Result<()> {
+ let table_scan = test_table_scan()?;
+ let left = LogicalPlanBuilder::from(table_scan)
+ .project(vec![col("a")])?
+ .build()?;
+ let right_table_scan = test_table_scan_with_name("test2")?;
+ let right = LogicalPlanBuilder::from(right_table_scan)
+ .project(vec![col("a")])?
+ .build()?;
+ let filter = col("test.a").gt(lit(1u32));
+ let plan = LogicalPlanBuilder::from(left)
+ .join(
+ &right,
+ JoinType::Inner,
+ (vec![Column::from_name("a")], vec![Column::from_name("a")]),
+ Some(filter),
+ )?
+ .build()?;
+
+ // not part of the test, just good to know:
+ assert_eq!(
+ format!("{:?}", plan),
+ "\
+ Inner Join: #test.a = #test2.a Filter: #test.a > UInt32(1)\
+ \n Projection: #test.a\
+ \n TableScan: test projection=None\
+ \n Projection: #test2.a\
+ \n TableScan: test2 projection=None"
+ );
+
+ let expected = "\
+ Inner Join: #test.a = #test2.a\
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
