pitrou commented on code in PR #13150:
URL: https://github.com/apache/arrow/pull/13150#discussion_r884789178
##########
cpp/src/arrow/compute/api_aggregate.h:
##########
@@ -480,6 +480,12 @@ struct ARROW_EXPORT Aggregate {
/// options for the aggregation function
const FunctionOptions* options;
Review Comment:
Why should it be `unique_ptr`? It's not obvious there's a need for ownership
here; also, the caller might want to keep ownership as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
