[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #2671: If statistics of column Max/Min value does not exists in parquet file, sent Min/Max to None

Wed, 01 Jun 2022 14:04:08 -0700 


alamb commented on code in PR #2671:
URL: https://github.com/apache/arrow-datafusion/pull/2671#discussion_r887296508


##########
datafusion/core/src/datasource/file_format/parquet.rs:
##########
@@ -344,6 +362,10 @@ fn fetch_statistics(
                             table_idx,
                             stats,
                         )
+                    } else {
+                        // If none statistics of current column exists, set 
the Max/Min Accumulator to None.

Review Comment:
   If there are no statistics in one of the row groups, I wonder if it is 
correct to keep going 🤔 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to